gh-149171: Make TypeAliasType __module__ writable#149172
Open
ericmarkmartin wants to merge 2 commits intopython:mainfrom
Open
gh-149171: Make TypeAliasType __module__ writable#149172ericmarkmartin wants to merge 2 commits intopython:mainfrom
ericmarkmartin wants to merge 2 commits intopython:mainfrom
Conversation
ddb11af to
73111a0
Compare
This was referenced Apr 30, 2026
picnixz
reviewed
Apr 30, 2026
Member
picnixz
left a comment
There was a problem hiding this comment.
You should update the TypeAlias docs (both rST and the one at L2193).
Comment on lines
+2005
to
+2007
| PyObject *old_module = ta->module; | ||
| Py_XDECREF(old_module); | ||
| ta->module = Py_XNewRef(value); |
Member
There was a problem hiding this comment.
Use Py_XSETREF instead. More generally, making it writable looks like we may introduce races on the free-threaded build so I think the getter/setter will need a critical section. I however don't know whether this should be considered an atomic change or not.
Documentation build overview
14 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #149171.