Make TypeAliasType __module__ writable#744
Open
ericmarkmartin wants to merge 3 commits intopython:mainfrom
Open
Make TypeAliasType __module__ writable#744ericmarkmartin wants to merge 3 commits intopython:mainfrom
ericmarkmartin wants to merge 3 commits intopython:mainfrom
Conversation
Author
|
I still need to add a changelog entry here |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #744 +/- ##
==========================================
- Coverage 97.38% 96.76% -0.63%
==========================================
Files 3 3
Lines 7690 7691 +1
==========================================
- Hits 7489 7442 -47
- Misses 201 249 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
c9b4323 to
332c96a
Compare
332c96a to
4214724
Compare
JelleZijlstra
approved these changes
May 1, 2026
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good, but going to wait until the CPython PR lands
Member
|
One more tests needs updating |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python/cpython#149172