gh-149009: Validate thread_count in profiling.sampling binary reader#149147
Open
maurycy wants to merge 3 commits intopython:mainfrom
Open
gh-149009: Validate thread_count in profiling.sampling binary reader#149147maurycy wants to merge 3 commits intopython:mainfrom
thread_count in profiling.sampling binary reader#149147maurycy wants to merge 3 commits intopython:mainfrom
Conversation
maurycy
commented
Apr 29, 2026
| } | ||
| } | ||
|
|
||
| if (reader->thread_state_count >= reader->thread_count) { |
Contributor
Author
There was a problem hiding this comment.
Wondering if there should be no hard cap but it's pairs and...
cpython/Modules/_remote_debugging/frames.c
Line 436 in d4eee16
cpython/Modules/_remote_debugging/frames.c
Line 418 in d4eee16
...the multiplication is still large.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
profiling.samplingbinary reader readsthread_countstored in the file header but replay does not validate if there's more(thread_id, interp_id)pairs than declared.To make it clear: that's just a validation.
Resolves gh-149009