tools: implements a few nits on build-aarch64-linux-v8#63048
Open
aduh95 wants to merge 2 commits intonodejs:mainfrom
Open
tools: implements a few nits on build-aarch64-linux-v8#63048aduh95 wants to merge 2 commits intonodejs:mainfrom
build-aarch64-linux-v8#63048aduh95 wants to merge 2 commits intonodejs:mainfrom
Conversation
Rename things, and merge some steps. Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
libv8for the Nix export was not very informative, adding the arch and OS to make it clear it's platform specific, also a file extension, that should help folks understand what they're dealing with. (info about Nix ARchive format can be found at https://nix.dev/manual/nix/2.28/store/file-system-object/content-address#serial-nix-archive)Also, renaming some variables and steps, and merging
cachix-checkwithv8-drvto improve the general readability of the workflow IMO.