Skip to content

lib: reject SharedArrayBuffer in Blob constructor per spec#63046

Open
thisalihassan wants to merge 1 commit intonodejs:mainfrom
thisalihassan:blob-reject-sab-source
Open

lib: reject SharedArrayBuffer in Blob constructor per spec#63046
thisalihassan wants to merge 1 commit intonodejs:mainfrom
thisalihassan:blob-reject-sab-source

Conversation

@thisalihassan
Copy link
Copy Markdown
Contributor

This is the remaining piece of the work tracked in #59688. The Blob change is semver-major because today the call succeeds.
The shared BufferSource converter was made hot-path-friendly in #62833, so no per-call binding overhead is added here.
Refs: #59688
Refs: #62632

Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 30, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.63%. Comparing base (a7f487f) to head (3b082ef).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #63046   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files         708      708           
  Lines      220402   220408    +6     
  Branches    42271    42276    +5     
=======================================
+ Hits       197551   197559    +8     
+ Misses      14706    14700    -6     
- Partials     8145     8149    +4     
Files with missing lines Coverage Δ
lib/internal/blob.js 99.44% <100.00%> (+<0.01%) ⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added semver-major PRs that contain breaking changes and should be released in the next major version. request-ci Add this label to start a Jenkins CI on a PR. web-standards Issues and PRs related to Web APIs labels Apr 30, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

@Renegade334 Renegade334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@Renegade334 Renegade334 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. web-standards Issues and PRs related to Web APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants