Skip to content

Merge reference implementation SDK changes (2026-04-30)#144

Merged
edburns merged 4 commits intomainfrom
copilot/update-copilot-sdk-to-1-0-40-0
Apr 30, 2026
Merged

Merge reference implementation SDK changes (2026-04-30)#144
edburns merged 4 commits intomainfrom
copilot/update-copilot-sdk-to-1-0-40-0

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 30, 2026

Ports 4 commits from github/copilot-sdk (dd2dcbce42b726).

Before the change?

  • setForegroundSessionId() serialized its RPC request body as an ad-hoc Map.of("sessionId", ...), relying on Jackson's map handling rather than an explicit type
  • E2ETestContext did not set COPILOT_HOME, diverging from the reference test harness
  • scripts/codegen/package.json and pom.xml referenced @github/copilot@^1.0.36

After the change?

  • SetForegroundSessionRequest record (json package): explicit DTO for the session.setForeground payload — mirrors the AOT-safe SetForegroundSessionRequest record added in reference impl commit c63feb2

  • CopilotClient.setForegroundSessionId(): uses the new record instead of Map.of()

    // before
    .invoke("session.setForeground", Map.of("sessionId", sessionId), ...)
    // after
    .invoke("session.setForeground", new SetForegroundSessionRequest(sessionId), ...)
  • E2ETestContext: adds COPILOT_HOME alongside XDG_CONFIG_HOME / XDG_STATE_HOME

  • @github/copilot bumped to ^1.0.40-0 in package.json and pom.xml; generated Java RPC/event sources are already current (schemas unchanged at this version)

  • .lastmerge updated to e42b726ca42bd1b2e099a956c9287ba9435ba3e5

Not ported: SessionFsTests path refactoring and MultiClientTests timing fix — no Java equivalents exist yet.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • mvn spotless:apply has been run to format the code
  • mvn clean verify passes locally

Does this introduce a breaking change?

  • Yes
  • No

Copilot AI and others added 3 commits April 30, 2026 10:48
…om.xml CLI version, and update scripts/codegen @github/copilot version

Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Copilot AI changed the title [WIP] Sync reference implementation with 4 new commits from Copilot SDK Merge reference implementation SDK changes (2026-04-30) Apr 30, 2026
Copilot AI requested a review from edburns April 30, 2026 10:59
@edburns edburns marked this pull request as ready for review April 30, 2026 16:58
Copilot AI review requested due to automatic review settings April 30, 2026 16:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ports recent reference-implementation updates into the Java SDK to keep request DTOs, test harness environment, and codegen dependency versions aligned with github/copilot-sdk at .lastmerge e42b726….

Changes:

  • Introduce SetForegroundSessionRequest DTO and use it in CopilotClient.setForegroundSessionId() instead of an ad-hoc Map.
  • Align E2E test harness environment with reference by setting COPILOT_HOME.
  • Bump @github/copilot used by codegen/test harness inputs to ^1.0.40-0 and update .lastmerge.
Show a summary per file
File Description
src/test/java/com/github/copilot/sdk/E2ETestContext.java Adds COPILOT_HOME to the environment passed to the CLI during E2E tests.
src/test/java/com/github/copilot/sdk/DataObjectCoverageTest.java Adds coverage for the new SetForegroundSessionRequest record.
src/main/java/com/github/copilot/sdk/json/SetForegroundSessionRequest.java New explicit request DTO for session.setForeground payload serialization.
src/main/java/com/github/copilot/sdk/CopilotClient.java Switches setForegroundSessionId() to send the new request DTO.
scripts/codegen/package.json Bumps @github/copilot dependency for codegen to ^1.0.40-0.
scripts/codegen/package-lock.json Locks @github/copilot and platform packages to 1.0.40-0.
pom.xml Updates the reference-impl CLI version property to ^1.0.40-0.
.lastmerge Updates tracked reference implementation commit to e42b726….

Copilot's findings

Files not reviewed (1)
  • scripts/codegen/package-lock.json: Language not supported
  • Files reviewed: 7/8 changed files
  • Comments generated: 1

Comment thread pom.xml
@edburns edburns merged commit fcec7ff into main Apr 30, 2026
15 checks passed
@edburns edburns deleted the copilot/update-copilot-sdk-to-1-0-40-0 branch April 30, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reference implementation sync: 4 new commits (2026-04-30)

3 participants