Swift: Add type inference tests#21777
Open
hvitved wants to merge 1 commit intogithub:mainfrom
Open
Conversation
b98238d to
4042bbe
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Swift type-inference library test suite using inline expectations (similar in spirit to existing Rust type inference tests) to validate inferred types and resolved targets.
Changes:
- Introduces a large Swift test corpus (
typeinference.swift) with inline// $ type=...and// $ target=...expectations. - Adds a new QL test driver (
type-inference.ql) that interprets inline expectations for resolved targets and inferred types. - Adds an (intentionally) empty
.expectedfile for the inline-expectations-based test.
Show a summary per file
| File | Description |
|---|---|
| swift/ql/test/library-tests/type-inference/typeinference.swift | New Swift source corpus containing inline type/target expectations. |
| swift/ql/test/library-tests/type-inference/type-inference.ql | New inline-expectations test query for resolution + type inference. |
| swift/ql/test/library-tests/type-inference/type-inference.expected | Empty expected file consistent with inline expectations tests. |
Copilot's findings
Comments suppressed due to low confidence (1)
swift/ql/test/library-tests/type-inference/typeinference.swift:1061
- This section is labeled “subscript overloading”, but the code defines overloaded
getmethods rather than Swiftsubscriptdeclarations. If the intent is to test subscript resolution/type inference, it would be better to implement real subscripts (e.g.,subscript(_ index: Int)andsubscript(_ key: String)) and update the expectations; otherwise, rename the section to avoid misleading coverage.
// --- Overload: subscript overloading ---
class MultiSubscript {
var data : [Int] = [1, 2, 3]
var dict : [String: Int] = ["a": 1]
// MultiSubscript.init
init() {}
// MultiSubscript.get(_:)
func get(_ index: Int) -> Int {
return data[index]
}
// MultiSubscript.get(_:String)
func get(_ key: String) -> Int {
return dict[key] ?? 0
}
}
- Files reviewed: 2/3 changed files
- Comments generated: 3
Comment on lines
+669
to
+692
| // --- Overload by return type (contextual type) --- | ||
|
|
||
| class OverloadByReturn { | ||
| // OverloadByReturn.create()->Int | ||
| func create() -> Int { | ||
| return 0 | ||
| } | ||
|
|
||
| // OverloadByReturn.create()->String | ||
| func create() -> String { | ||
| return "" | ||
| } | ||
|
|
||
| // OverloadByReturn.create()->Double | ||
| func create() -> Double { | ||
| return 0.0 | ||
| } | ||
| } | ||
|
|
||
| func testOverloadByReturn() { | ||
| let o = OverloadByReturn() // $ target=init() | ||
| let r1 : Int = o.create() // $ type=r1:Int target=OverloadByReturn.create()->Int | ||
| let r2 : String = o.create() // $ type=r2:String target=OverloadByReturn.create()->String | ||
| let r3 : Double = o.create() // $ type=r3:Double target=OverloadByReturn.create()->Double |
Comment on lines
+243
to
+257
| // --- Subscripts --- | ||
|
|
||
| struct Matrix { | ||
| var data : [[Int]] | ||
|
|
||
| // Matrix.init | ||
| init(data: [[Int]]) { | ||
| self.data = data | ||
| } | ||
|
|
||
| // Matrix.rowCount | ||
| func rowCount() -> Int { | ||
| return data.count | ||
| } | ||
| } |
| @@ -0,0 +1,1372 @@ | |||
| var topLevelDecl : Int = 0 | |||
| 0 | |||
jketema
approved these changes
May 1, 2026
Contributor
jketema
left a comment
There was a problem hiding this comment.
LGTM.
Should there also be tests related to key paths?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a bunch of test cases for verifying inferred types, similar to what we have for Rust. Most of the tests have been written using Copilot CLI, but I have verified and tweaked them manually afterwards.